This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Allow full kustomisation of aad-msi-binding.yaml #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the name of the AzureIdentity/AzureIdentityBinding objects
created as part of the aad-pod-identity lz addon have hardcoded names.
This made it not possible to create more than one pair for one MSI.
This patch applies kustomise to each field allowing for more
customisation.
It also adds a new 'selector' argument in the case the user doesn't want
the name of the MSI used in this field:
managed_identities = {
ingress_msi = {
lz_key = "aks"
aadpodidentity_selector = "ingress"
msi_keys = [
"ingress",
]
}
}
If aadpodidentity_selector is not specified the MSI name is used as
before.
brk3
changed the title
hieumoscow
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
LGTM, thanks @brk3
Before we did allow to specify selector value but tfvar was quite verbose. I like this approach as msi name might contains weird characters that breaks the creation of azureidentity & azureidentitybinding. Cheers
LaurentLesle
approved these changes
Dec 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the name of the
AzureIdentity/AzureIdentityBindingobjectscreated as part of the
aad-pod-identitylz addon have hardcoded names.This made it not possible to create more than one pair for one MSI.
This patch applies
kustomiseto each field allowing for morecustomisation.
It also adds a new 'selector' argument in the case the user doesn't want
the name of the MSI used in this field:
If
aadpodidentity_selectoris not specified the MSI name is used asbefore.
PR Checklist
Description
Does this introduce a breaking change
Testing